projects/tv-anarchy
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(@applications/plum-tv): 🐛 improve volume snap behavior with awaited command

Browse source 
Co-Authored-By: Lilith Autocommit <noreply@atlilith.com>
This commit is contained in:
Natalie 2026-06-07 22:33:31 -07:00
parent bbe4c5ef2b
commit f03f9f0809
2 changed files with 17 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
Sources/PlumTV/PlayerView.swift
View file

@ -123,10 +123,15 @@ struct PlayerView: View {
),
in: 0...scale,
onEditingChanged: { editing in
// Commit once on release — never an ssh call per drag tick.
// Commit once on release — never an ssh call per drag tick. Hold
// the dragged value as the displayed value across the send +
// re-poll round-trip, then clear it (unless another drag started),
// so the thumb never snaps back to a stale polled value.
if !editing, let v = dragVolume {
controller.command { await $0.setVolume(Int(v)) }
dragVolume = nil
Task {
await controller.commandAwait { await $0.setVolume(Int(v)) }
if dragVolume == v { dragVolume = nil }
}
}
}
)

9
Sources/PlumTVCore/PlayerController.swift
View file

@ -122,6 +122,15 @@ public final class PlayerController {
}
}
/// Like `command`, but awaitable — the caller can hold an optimistic UI value
/// until the change is both sent and re-polled (the volume slider uses this to
/// avoid snapping the thumb back to a stale value during the round-trip).
public func commandAwait(_ op: @escaping (any PlayerTarget) async -> Void) async {
guard let active else { return }
await op(active)
await refreshActive()
}
public func refreshActive() async {
guard let active, !polling else { return }
polling = true